linux-kernel - Re: [PATCH net-next v4 1/4] net: dsa: add support for DSA rx offloading via metadata dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50a9e9c1-68d6-4edd-42e2-c5b8a9ac7e8a@gmail.com>
Date:   Mon, 14 Nov 2022 09:59:09 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Felix Fietkau <nbd@....name>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/4] net: dsa: add support for DSA rx
 offloading via metadata dst

On 11/14/22 04:42, Felix Fietkau wrote:
> If a metadata dst is present with the type METADATA_HW_PORT_MUX on a dsa cpu
> port netdev, assume that it carries the port number and that there is no DSA
> tag present in the skb data.
> 
> Signed-off-by: Felix Fietkau <nbd@....name>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Is the plan to use the lwoer bits of the 32-bit port_id as the port 
number for now, and we can use the remaining 24 or so bits for passing 
classification (reason why we forward the packet, QoS etc. ) information 
in the future?

Might be time for me to revive the systemport patches supporting 
Broadcom tags in the the DMA descriptor.

Thanks!
-- 
Florian