[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAP-5=fV6bzkyxf=Uw3ugA_W=v-M=eLGueMXWQj20HzCfUAJ18Q@mail.gmail.com>
Date: Mon, 14 Nov 2022 10:21:22 -0800
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
LKML <linux-kernel@...r.kernel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
linux-perf-users@...r.kernel.org,
Kan Liang <kan.liang@...ux.intel.com>,
Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
James Clark <james.clark@....com>
Subject: Re: [PATCH 11/11] perf stat: Add missing separator in the CSV header
On Fri, Nov 11, 2022 at 7:23 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> It should have a comma after 'cpus' for socket and die aggregation mode.
> The output of the following command shows the issue.
>
> $ sudo perf stat -a --per-socket -x, --metric-only -I1 true
>
> Before:
> +--- here
> V
> time,socket,cpusGhz,insn per cycle,branch-misses of all branches,
> 0.000908461,S0,8,0.950,1.65,1.21,
>
> After:
> time,socket,cpus,GHz,insn per cycle,branch-misses of all branches,
> 0.000683094,S0,8,0.593,2.00,0.60,
>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
Acked-by: Ian Rogers <irogers@...gle.com>
Thanks,
Ian
> ---
> tools/perf/util/stat-display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 96bb7a42fd41..a316807255cd 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -828,8 +828,8 @@ static int aggr_header_lens[] = {
>
> static const char *aggr_header_csv[] = {
> [AGGR_CORE] = "core,cpus,",
> - [AGGR_DIE] = "die,cpus",
> - [AGGR_SOCKET] = "socket,cpus",
> + [AGGR_DIE] = "die,cpus,",
> + [AGGR_SOCKET] = "socket,cpus,",
> [AGGR_NONE] = "cpu,",
> [AGGR_THREAD] = "comm-pid,",
> [AGGR_NODE] = "node,",
> --
> 2.38.1.493.g58b659f92b-goog
>
Powered by blists - more mailing lists