linux-kernel - Re: [PATCH] KVM: x86/xen: Make number of event channels defines less magical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <629d6d90ce95b9db74f0101a4428be1119c4bfc7.camel@infradead.org>
Date:   Mon, 14 Nov 2022 10:39:15 -0800
From:   David Woodhouse <dwmw2@...radead.org>
To:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paul Durrant <paul@....org>
Subject: Re: [PATCH] KVM: x86/xen: Make number of event channels defines
 less magical

On Mon, 2022-11-14 at 18:16 +0000, Sean Christopherson wrote:
> Use BITS_PER_BYTE and sizeof_field() to compute the number of Xen event
> channels.  The compat version at least uses sizeof_field(), but the
> regular version open codes sizeof_field(), BITS_PER_BYTE, and combines
> literals in the process, which makes it far too difficult to understand
> relatively straightforward code.
> 
> No functional change intended.

Slightly dubious about changing the regular one, since that's just
imported directly from Xen public header files.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)