linux-kernel - Re: [PATCH v6 1/1] i2c: Restore initial power state if probe fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3KbYLSFLUuVnSIa@shikoro>
Date:   Mon, 14 Nov 2022 20:47:44 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Ricardo Ribalda <ribalda@...omium.org>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Tomasz Figa <tfiga@...omium.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Hidenori Kobayashi <hidenorik@...omium.org>,
        stable@...r.kernel.org,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        linux-kernel@...r.kernel.org,
        Hidenori Kobayashi <hidenorik@...gle.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH v6 1/1] i2c: Restore initial power state if probe fails

wOn Mon, Nov 14, 2022 at 01:20:34PM +0100, Ricardo Ribalda wrote:
> A driver that supports I2C_DRV_ACPI_WAIVE_D0_PROBE is not expected to
> power off a device that it has not powered on previously.
> 
> For devices operating in "full_power" mode, the first call to
> `i2c_acpi_waive_d0_probe` will return 0, which means that the device
> will be turned on with `dev_pm_domain_attach`.
> 
> If probe fails the second call to `i2c_acpi_waive_d0_probe` will
> return 1, which means that the device will not be turned off.
> This is, it will be left in a different power state. Lets fix it.
> 
> Reviewed-by: Hidenori Kobayashi <hidenorik@...omium.org>
> Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>
> Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Cc: stable@...r.kernel.org
> Fixes: b18c1ad685d9 ("i2c: Allow an ACPI driver to manage the device's power state during probe")
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)