linux-kernel - Re: [patch 03/10] scsi: lpfc: Remove linux/msi.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Nov 2022 21:39:42 -0800
From:   James Smart <jsmart2021@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Marc Zyngier <maz@...nel.org>,
        James Smart <james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [patch 03/10] scsi: lpfc: Remove linux/msi.h include

On 11/13/2022 12:33 PM, Thomas Gleixner wrote:
> Nothing in this file needs anything from linux/msi.h
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: James Smart <james.smart@...adcom.com>
> Cc: Dick Kennedy <dick.kennedy@...adcom.com>
> Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: linux-scsi@...r.kernel.org
> ---
>   drivers/scsi/lpfc/lpfc_init.c |    1 -
>   1 file changed, 1 deletion(-)
> 
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -36,7 +36,6 @@
>   #include <linux/firmware.h>
>   #include <linux/miscdevice.h>
>   #include <linux/percpu.h>
> -#include <linux/msi.h>
>   #include <linux/irq.h>
>   #include <linux/bitops.h>
>   #include <linux/crash_dump.h>
> 

yep - agree.

Reviewed-by: James Smart <jsmart2021@...il.com>

-- james