linux-kernel - Re: [PATCH] HSI: omap_ssi_core: fix unbalanced pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221114205124.xqce2uz3ktegsqlk@mercury.elektranox.org>
Date:   Mon, 14 Nov 2022 21:51:24 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, carlos.chinea@...ia.com,
        ivo.g.dimitrov.75@...il.com
Subject: Re: [PATCH] HSI: omap_ssi_core: fix unbalanced pm_runtime_disable()

Hi,

On Tue, Nov 01, 2022 at 11:41:18AM +0800, Yang Yingliang wrote:
> In error label 'out1' path in ssi_probe(), the pm_runtime_enable()
> has not been called yet, so pm_runtime_disable() is not needed.
> 
> Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/hsi/controllers/omap_ssi_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
> index 80bf09bc5d15..052cf3e92dd6 100644
> --- a/drivers/hsi/controllers/omap_ssi_core.c
> +++ b/drivers/hsi/controllers/omap_ssi_core.c
> @@ -538,9 +538,9 @@ static int ssi_probe(struct platform_device *pd)
>  	device_for_each_child(&pd->dev, NULL, ssi_remove_ports);
>  out2:
>  	ssi_remove_controller(ssi);
> +	pm_runtime_disable(&pd->dev);
>  out1:
>  	platform_set_drvdata(pd, NULL);
> -	pm_runtime_disable(&pd->dev);
>  
>  	return err;
>  }
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)