linux-kernel - Re: [PATCH v3] btrfs: volumes: Increase bioc pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221114205506.GC5824@twin.jikos.cz>
Date:   Mon, 14 Nov 2022 21:55:06 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Li zeming <zeming@...china.com>
Cc:     clm@...com, josef@...icpanda.com, dsterba@...e.com,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] btrfs: volumes: Increase bioc pointer check

On Wed, Oct 26, 2022 at 09:36:11AM +0800, Li zeming wrote:
> The __GFP_NOFAIL flag will cause memory to be allocated an infinite
> number of times until the allocation is successful, but it is best to
> use it only for very necessary code, and try not to use it.
> 
> The alloc_btrfs_io_context function looks a little closer to normal
> (excuse my analysis), but I think we can remove __GFP_NOFAIL from it and
> add a bioc pointer allocation check that returns NULL if the allocation
> fails.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

I've reworded the subject and changelog and patch is now in misc-next,
thanks.