linux-kernel - Re: [PATCH] HID: hid-lg4ff: Add check for empty lbuf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2211142357170.6045@cbobk.fhfr.pm>
Date:   Mon, 14 Nov 2022 23:57:52 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Anastasia Belova <abelova@...ralinux.ru>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Michal Malý <madcatxster@...oid-pointer.net>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH] HID: hid-lg4ff: Add check for empty lbuf

On Fri, 11 Nov 2022, Anastasia Belova wrote:

> If an empty buf is received, lbuf is also empty. So lbuf is 
> accessed by index -1.

Good catch, thanks!

> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: f31a2de3fe36 ("HID: hid-lg4ff: Allow switching of Logitech gaming wheels between compatibility modes")
> 
> Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>

I've put the Fixes: line into the SOB/metadata space, and applied. Thank 
you,

-- 
Jiri Kosina
SUSE Labs