linux-kernel - Re: [PATCH] drivers: undo simplify POWER_SUPPLY_PROP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2022 07:22:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Elijah Conners <business@...jahpepe.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-pm <linux-pm@...r.kernel.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        mszyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH] drivers: undo simplify POWER_SUPPLY_PROP_ONLINE

Hi Elijah,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sre-power-supply/for-next]
[also build test ERROR on linus/master v6.1-rc5 next-20221114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Elijah-Conners/drivers-undo-simplify-POWER_SUPPLY_PROP_ONLINE/20221114-222633
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/184767a4f60.d9a0c3da334147.3171681720569322283%40elijahpepe.com
patch subject: [PATCH] drivers: undo simplify POWER_SUPPLY_PROP_ONLINE
config: m68k-randconfig-r022-20221114
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/3cd836a257978f45593135825f6886891b9dac54
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Elijah-Conners/drivers-undo-simplify-POWER_SUPPLY_PROP_ONLINE/20221114-222633
        git checkout 3cd836a257978f45593135825f6886891b9dac54
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/power/supply/max17040_battery.c: In function 'max17040_get_online':
>> drivers/power/supply/max17040_battery.c:220:22: error: 'struct max17040_chip' has no member named 'pdata'; did you mean 'data'?
     220 |         return chip->pdata && chip->pdata->battery_online ?
         |                      ^~~~~
         |                      data
   drivers/power/supply/max17040_battery.c:220:37: error: 'struct max17040_chip' has no member named 'pdata'; did you mean 'data'?
     220 |         return chip->pdata && chip->pdata->battery_online ?
         |                                     ^~~~~
         |                                     data
   drivers/power/supply/max17040_battery.c:221:23: error: 'struct max17040_chip' has no member named 'pdata'; did you mean 'data'?
     221 |                 chip->pdata->battery_online() : 1;
         |                       ^~~~~
         |                       data
   drivers/power/supply/max17040_battery.c:222:1: error: control reaches end of non-void function [-Werror=return-type]
     222 | }
         | ^
   cc1: some warnings being treated as errors


vim +220 drivers/power/supply/max17040_battery.c

   217	
   218	static int max17040_get_online(struct max17040_chip *chip)
   219	{
 > 220		return chip->pdata && chip->pdata->battery_online ?
   221			chip->pdata->battery_online() : 1;
   222	}
   223	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (136490 bytes)