linux-kernel - Re: [PATCH] mm/kfence: remove hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANpmjNNYRg7sYTxKN_YCts7wqGfr-2YZbw+pwdO5nTZp_bBVfg@mail.gmail.com>
Date:   Mon, 14 Nov 2022 08:00:00 +0100
From:   Marco Elver <elver@...gle.com>
To:     Pavankumar Kondeti <quic_pkondeti@...cinc.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        kasan-dev@...glegroups.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/kfence: remove hung_task cruft

On Wed, 9 Nov 2022 at 10:26, Pavankumar Kondeti
<quic_pkondeti@...cinc.com> wrote:
>
> commit fdf756f71271 ("sched: Fix more TASK_state comparisons") makes
> hung_task not to monitor TASK_IDLE tasks. The special handling to
> workaround hung_task warnings is not required anymore.
>
> Signed-off-by: Pavankumar Kondeti <quic_pkondeti@...cinc.com>

Good riddance, thanks.

Reviewed-by: Marco Elver <elver@...gle.com>

> ---
>  mm/kfence/core.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> index 1417888..08f5bd6 100644
> --- a/mm/kfence/core.c
> +++ b/mm/kfence/core.c
> @@ -26,7 +26,6 @@
>  #include <linux/random.h>
>  #include <linux/rcupdate.h>
>  #include <linux/sched/clock.h>
> -#include <linux/sched/sysctl.h>
>  #include <linux/seq_file.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
> @@ -799,16 +798,7 @@ static void toggle_allocation_gate(struct work_struct *work)
>         /* Enable static key, and await allocation to happen. */
>         static_branch_enable(&kfence_allocation_key);
>
> -       if (sysctl_hung_task_timeout_secs) {
> -               /*
> -                * During low activity with no allocations we might wait a
> -                * while; let's avoid the hung task warning.
> -                */
> -               wait_event_idle_timeout(allocation_wait, atomic_read(&kfence_allocation_gate),
> -                                       sysctl_hung_task_timeout_secs * HZ / 2);
> -       } else {
> -               wait_event_idle(allocation_wait, atomic_read(&kfence_allocation_gate));
> -       }
> +       wait_event_idle(allocation_wait, atomic_read(&kfence_allocation_gate));
>
>         /* Disable static key and reset timer. */
>         static_branch_disable(&kfence_allocation_key);
> --
> 2.7.4
>