[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221114070702.1887144-1-ruanjinjie@huawei.com>
Date: Mon, 14 Nov 2022 15:07:02 +0800
From: ruanjinjie <ruanjinjie@...wei.com>
To: <jgross@...e.com>, <sstabellini@...nel.org>,
<oleksandr_tyshchenko@...m.com>, <xen-devel@...ts.xenproject.org>,
<linux-kernel@...r.kernel.org>
CC: <ruanjinjie@...wei.com>
Subject: [PATCH] xen: add missing free_irq() in error path
free_irq() is missing in case of error, fix that.
Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>
---
drivers/xen/platform-pci.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 18f0ed8b1f93..6ebd819338ec 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -144,7 +144,7 @@ static int platform_pci_probe(struct pci_dev *pdev,
if (ret) {
dev_warn(&pdev->dev, "Unable to set the evtchn callback "
"err=%d\n", ret);
- goto out;
+ goto irq_out;
}
}
@@ -152,13 +152,16 @@ static int platform_pci_probe(struct pci_dev *pdev,
grant_frames = alloc_xen_mmio(PAGE_SIZE * max_nr_gframes);
ret = gnttab_setup_auto_xlat_frames(grant_frames);
if (ret)
- goto out;
+ goto irq_out;
ret = gnttab_init();
if (ret)
goto grant_out;
return 0;
grant_out:
gnttab_free_auto_xlat_frames();
+irq_out:
+ if (!xen_have_vector_callback)
+ free_irq(pdev->irq, pdev);
out:
pci_release_region(pdev, 0);
mem_out:
--
2.25.1
Powered by blists - more mailing lists