[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y3H1xjtl+dMGssDU@hovoldconsulting.com>
Date: Mon, 14 Nov 2022 09:01:10 +0100
From: Johan Hovold <johan@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Johan Hovold <johan+linaro@...nel.org>,
Vinod Koul <vkoul@...nel.org>, Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] phy: qcom-qmp-combo: fix runtime suspend
On Sat, Nov 12, 2022 at 09:17:29AM +0300, Dmitry Baryshkov wrote:
> On 11/11/2022 11:42, Johan Hovold wrote:
> > Drop the confused runtime-suspend type check which effectively broke
> > runtime PM if the DP child node happens to be parsed before the USB
> > child node during probe (e.g. due to order of child nodes in the
> > devicetree).
> >
> > Instead use the new driver data USB PHY pointer to access the USB
> > configuration and resources.
> >
> > Fixes: ac0d239936bd ("phy: qcom-qmp: Add support for runtime PM")
>
> I belive the Fixes tag is incorrect. One can not easily backport this
> patch on top of the original ac0d239936bd. I'd suggest to point the
> Fixes tags to the addition of phy-qcom-qmp-combo.c
The Fixes tag should document the commit introducing the bug regardless
of what kind of changes happened in between.
That said, the tag should have been
Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")
as this wasn't an issue before adding DP support, which intentionally
relied on these hard-coded indexes ("luckily USB3 is the first phy").
Johan
Powered by blists - more mailing lists