linux-kernel - Re: [v2 1/3] dt-bindings: Add bindings for aspeed pwm-tach.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D453751F-9FA5-4046-BC5F-866D11010805@aspeedtech.com>
Date:   Mon, 14 Nov 2022 08:26:49 +0000
From:   Billy Tsai <billy_tsai@...eedtech.com>
To:     Rob Herring <robh@...nel.org>
CC:     "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "joel@....id.au" <joel@....id.au>,
        "andrew@...id.au" <andrew@...id.au>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
        BMC-SW <BMC-SW@...eedtech.com>,
        "garnermic@...a.com" <garnermic@...a.com>
Subject: Re: [v2 1/3] dt-bindings: Add bindings for aspeed pwm-tach.

Hi Rob,

On 2022/11/3, 3:39 PM, "Billy Tsai" <billy_tsai@...eedtech.com> wrote:

    On 2022/11/3, 2:19 AM, "Rob Herring" <robh@...nel.org> wrote:

        On Tue, Nov 1, 2022 at 10:21 PM Billy Tsai <billy_tsai@...eedtech.com> wrote:

    >    > That all sounds like requirements that you have which you should
    >    > ensure the fan binding can support.

    >    > I've already said to use the PWM binding in the fan binding exactly
    >    > for the purpose of hooking up the PWMs to other things. Whether the
    >    > tach controller is useful for something other than fans, I don't know.
    >    > Seems less likely. The max6639 also has a tach controller. So if other
    >    > uses are possible for you, then it could be possible for any other h/w
    >    > like the max6639.

    > The linux kernel already have the similar binding:
    > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/hwmon/pwm-fan.txt 
    > Therefore, I want to reuse it and the pwm-fan.c instead of creating another similar fan binding and driver.
    > I am referring to the following files:
    > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/mfd/kontron%2Csl28cpld.yaml 
    > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pwm/kontron%2Csl28cpld-pwm.yaml 
    > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/hwmon/kontron%2Csl28cpld-hwmon.yaml 
    > It will also reuse the pwm-fan instead creating it own pwm-fan binding for their hwmon(tach).
    > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts#L20 

Do you have any sugguest about the binding like the link above?
We can just creat the pure PWM provider and use the pwm-fan as the common fan binding instead of creating another fan-common.yaml.

Thanks

Best Regards,
Billy Tsai