linux-kernel - Re: [PATCH net-next] net: dcb: move getapptrust to separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3ICvKvpiG+Rn+2h@DEN-LT-70577>
Date:   Mon, 14 Nov 2022 08:45:42 +0000
From:   <Daniel.Machon@...rochip.com>
To:     <joe@...ches.com>
CC:     <petrm@...dia.com>, <netdev@...r.kernel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <vladimir.oltean@....com>,
        <linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
        <lkp@...el.com>
Subject: Re: [PATCH net-next] net: dcb: move getapptrust to separate function

> > > > +
> > > > +             err = -EMSGSIZE;
> > > > +
> > > > +             apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE);
> > > > +             if (!apptrust)
> > > > +                     goto nla_put_failure;
> > > > +
> > > > +             for (i = 0; i < nselectors; i++) {
> > > > +                     enum ieee_attrs_app type =
> > > > +                             dcbnl_app_attr_type_get(selectors[i]);
> > >
> > > Doesn't checkpatch warn about this? There should be a blank line after
> > > the variable declaration block. (Even if there wasn't one there in the
> > > original code either.)
> >
> > Nope, no warning. And I think it has something to do with the way the line
> > is split.
> 
> yup.
> 
> And style trivia:
> 
> I suggest adding error types after specific errors,
> reversing the test and unindenting the code too.
> 
> Something like:
> 
>         err = ops->dcbnl_getapptrust(netdev, selectors, &nselectors);
>         if (err) {
>                 err = 0;
>                 goto out;
>         }
> 
>         apptrust = nla_nest_start(skb, DCB_ATTR_DCB_APP_TRUST_TABLE);
>         if (!apptrust) {
>                 err = -EMSGSIZE;
>                 goto out;
>         }
> 
>         for (i = 0; i < nselectors; i++) {
>                 enum ieee_attrs_app type = dcbnl_app_attr_type_get(selectors[i]);
>                 err = nla_put_u8(skb, type, selectors[i]);
>                 if (err) {
>                         nla_nest_cancel(skb, apptrust);
>                         goto out;
>                 }
>         }
>         nla_nest_end(skb, apptrust);
> 
>         err = 0;
> 
> out:
>         kfree(selectors);
>         return err;
> }
>

LGTM.

The last err = 0 can even be removed, as I see it.
Will submit a new version with the changes suggested.

/ Daniel