[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3IOEFTZ1e/7uWJ4@smile.fi.intel.com>
Date: Mon, 14 Nov 2022 11:44:48 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Rahul Tanwar <rtanwar@...linear.com>
Cc: bigeasy@...utronix.de, robh@...nel.org, tglx@...utronix.de,
mingo@...hat.com, bp@...en8.de, x86@...nel.org, hpa@...or.com,
dave.hansen@...ux.intel.com, linux-kernel@...r.kernel.org,
linux-lgm-soc@...linear.com
Subject: Re: [PATCH RESEND 1/1] x86/of: Add support for boot time interrupt
mode config
On Mon, Nov 14, 2022 at 05:20:06PM +0800, Rahul Tanwar wrote:
> Presently, init/boot time interrupt delivery mode is enumerated only
> for ACPI enabled systems by parsing MADT table or for older systems
> by parsing MP table. But for OF based x86 systems, it is assumed &
> fixed to legacy PIC mode.
>
> Add support for configuration of init time interrupt delivery mode for
> x86 OF based systems by introducing a new optional boolean property
> 'intel,no-imcr' for interrupt-controller node of local APIC. This
> property emulates IMCRP Bit 7 of MP feature info byte 2 of MP
> floating pointer structure.
>
> Defaults to legacy PIC mode if absent. Configures it to virtual wire
> compatibility mode if present.
...
> + if (of_property_read_bool(dn, "intel,no-imcr")) {
I can't find this property in the Documentation/devicetree/bindings.
Moreover, I prefer to see positive one, something like:
intel,virtual-wire-bla-bla-bla
Please consult with DT people on how properly name it.
> + pr_info(" Virtual Wire compatibility mode.\n");
> + pic_mode = 0;
> + } else {
> + pr_info(" IMCR and PIC compatibility mode.\n");
> + pic_mode = 1;
> + }
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists