linux-kernel - Re: [PATCH] kselftest/cgroup: Fix gathering number of CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96eeeb5e-9fe9-ebf6-cc91-d49c86ec615d@oracle.com>
Date:   Mon, 14 Nov 2022 15:16:28 +0530
From:   Kamalesh Babulal <kamalesh.babulal@...cle.com>
To:     Breno Leitao <leitao@...ian.org>, tj@...nel.org,
        lizefan.x@...edance.com, hannes@...xchg.org, shuah@...nel.org,
        cgroups@...r.kernel.org
Cc:     leit@...a.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/cgroup: Fix gathering number of CPUs



On 11/13/22 17:14, Breno Leitao wrote:
> test_cpuset_prs.sh is failing with the following error:
> 
> 	test_cpuset_prs.sh: line 29: [[: 8
> 	57%: syntax error in expression (error token is "57%")
> 
> This is happening because `lscpu | grep "^CPU(s)"` returns two lines in
> some systems (such as Debian unstable):
> 
> 	# lscpu | grep "^CPU(s)"
> 	CPU(s):                          8
> 	CPU(s) scaling MHz:              55%
> 
> This is a simple fix that discard the second line.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Tested with util-linux v2.38

Reviewed-by: Kamalesh Babulal <kamalesh.babulal@...cle.com>

> ---
>  tools/testing/selftests/cgroup/test_cpuset_prs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cgroup/test_cpuset_prs.sh b/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> index 526d2c42d870..564ca8c33035 100755
> --- a/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> +++ b/tools/testing/selftests/cgroup/test_cpuset_prs.sh
> @@ -25,7 +25,7 @@ WAIT_INOTIFY=$(cd $(dirname $0); pwd)/wait_inotify
>  CGROUP2=$(mount -t cgroup2 | head -1 | awk -e '{print $3}')
>  [[ -n "$CGROUP2" ]] || skip_test "Cgroup v2 mount point not found!"
>  
> -CPUS=$(lscpu | grep "^CPU(s)" | sed -e "s/.*:[[:space:]]*//")
> +CPUS=$(lscpu | grep "^CPU(s):" | sed -e "s/.*:[[:space:]]*//")
>  [[ $CPUS -lt 8 ]] && skip_test "Test needs at least 8 cpus available!"
>  
>  # Set verbose flag and delay factor

-- 
Thanks,
Kamalesh