linux-kernel - Re: [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7 hardware for Exynos 3250 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1877eadd-e1c9-c08b-4e47-8b902a8b7dd9@linaro.org>
Date:   Mon, 14 Nov 2022 11:05:20 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Aakarsh Jain <aakarsh.jain@...sung.com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     m.szyprowski@...sung.com, andrzej.hajda@...el.com,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        ezequiel@...guardiasur.com.ar, jernej.skrabec@...il.com,
        benjamin.gaignard@...labora.com, krzysztof.kozlowski+dt@...aro.org,
        stanimir.varbanov@...aro.org, dillon.minfei@...il.com,
        david.plowman@...pberrypi.com, mark.rutland@....com,
        robh+dt@...nel.org, krzk+dt@...nel.org, andi@...zian.org,
        alim.akhtar@...sung.com, aswani.reddy@...sung.com,
        pankaj.dubey@...sung.com, smitha.t@...sung.com
Subject: Re: [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7
 hardware for Exynos 3250 SoC

On 14/11/2022 10:44, Aakarsh Jain wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
>> Sent: 14 November 2022 13:22
>> To: Aakarsh Jain <aakarsh.jain@...sung.com>; linux-arm-
>> kernel@...ts.infradead.org; linux-media@...r.kernel.org; linux-
>> kernel@...r.kernel.org; devicetree@...r.kernel.org
>> Cc: m.szyprowski@...sung.com; andrzej.hajda@...el.com;
>> mchehab@...nel.org; hverkuil-cisco@...all.nl;
>> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
>> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
>> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
>> david.plowman@...pberrypi.com; mark.rutland@....com;
>> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
>> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
>> pankaj.dubey@...sung.com; smitha.t@...sung.com
>> Subject: Re: [Patch v4 2/3] media: s5p-mfc: Add variant data for MFC v7
>> hardware for Exynos 3250 SoC
>>
>> On 14/11/2022 06:46, Aakarsh Jain wrote:
>>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for
>>
>> Please run scripts/checkpatch.pl and fix reported warnings.
>>
> Do you mean warnings on "5441e9dafdfc6dc40fa" commit? Or on this patch?
>  
> I am running like this :  ./scripts/checkpatch.pl patch_file, it does not show any warnings.
> 
> or am I missing anything while running checkpatch on the current patch?

Eh, you're right... checkpatch does not catch it. You need to fix syntax
- drop quotes, use proper commit title:

https://elixir.bootlin.com/linux/v5.19-rc1/source/Documentation/process/submitting-patches.rst#L100

Best regards,
Krzysztof