linux-kernel - Re: [PATCH v3 4/5] dt-bindings: soc: qcom: convert non-smd RPM bindings to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3IUfKyeP5IREdnZ@google.com>
Date:   Mon, 14 Nov 2022 10:12:12 +0000
From:   Lee Jones <lee@...nel.org>
To:     Neil Armstrong <neil.armstrong@...aro.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-gpio@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 4/5] dt-bindings: soc: qcom: convert non-smd RPM
 bindings to dt-schema

On Tue, 08 Nov 2022, Neil Armstrong wrote:

> Hi,
> 
> On 06/11/2022 04:48, Bjorn Andersson wrote:
> > On Fri, Oct 21, 2022 at 05:27:56PM +0200, Neil Armstrong wrote:
> > [..]
> > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml
> > > new file mode 100644
> > > index 000000000000..6531c8805894
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml
> > > @@ -0,0 +1,101 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,ipc-rpm.yaml#"
> > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > > +
> > > +title: Qualcomm Resource Power Manager (RPM) over IPC
> > 
> > It's true that there's something executing elsewhere in the SoC
> > acting upon the request written to the RPM memory region.
> > 
> > But for me the phrasing "over IPC" applies much more to the SMD/GLINK
> > variant than to this. So I would prefer to just name this
> > "qcom,rpm.yaml" and omit the "over IPC" phrasing.
> > 
> > 
> > Binding looks good to me.
> 
> Thanks I'll post a v4 with these changes,
> Rob, Lee, can I keep your current review tags with only the renaming and removal of " over IPC" in title ?

Yes, NP.

-- 
Lee Jones [李琼斯]