linux-kernel - Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2022 11:15:30 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Jon Hunter <jonathanh@...dia.com>, Wayne Chang <waynec@...dia.com>,
        mathias.nyman@...el.com, p.zabel@...gutronix.de,
        devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-tegra@...r.kernel.org, singhanc@...dia.com, balbi@...nel.org,
        linux-phy@...ts.infradead.org, vkoul@...nel.org, ajayg@...dia.com,
        heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org,
        treding@...dia.com, jckuo@...dia.com, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host
 controller binding

On Fri, Nov 11, 2022 at 11:32:36AM -0600, Rob Herring wrote:
> On Fri, Nov 11, 2022 at 02:38:21PM +0000, Jon Hunter wrote:
> > 
> > On 11/11/2022 13:30, Rob Herring wrote:
> > > 
> > > On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote:
> > > > Add device-tree binding documentation for the XUSB host controller present
> > > > on Tegra234 SoC. This controller supports the USB 3.1 specification.
> > > > 
> > > > Signed-off-by: Wayne Chang <waynec@...dia.com>
> > > > ---
> > > > V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml
> > > >   .../bindings/usb/nvidia,tegra234-xusb.yaml    | 159 ++++++++++++++++++
> > > >   1 file changed, 159 insertions(+)
> > > >   create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
> > > > 
> > > 
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dts:36.27-28 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dtb] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1492: dt_binding_check] Error 2
> > 
> > This compiles fine on top of -next. We are just missing the change that
> > populates the required definitions.
> 
> Where exactly is that mentioned in the commit msg?
> 
> No maintainer can take patches which apply against linux-next, so not a 
> good dependency to mention either.

It would probably be easiest for me to pick this up into the Tegra tree
since that's where the dt-bindings header file change is that adds these
symbols. Alternatively we could strip the symbols from the example and
use literals instead.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)