linux-kernel - RE: [PATCH] scripts: dev-needs.sh: Enforce bash usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cff9a58b31e3493fb1231db54705bb30@AcuMS.aculab.com>
Date:   Mon, 14 Nov 2022 10:30:29 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Steffen Kothe' <steffen.kothe@...the.de>,
        Saravana Kannan <saravanak@...gle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scripts: dev-needs.sh: Enforce bash usage

From: Steffen Kothe
> Sent: 12 November 2022 09:41
...
> What about a re-write of the script in POSIX compliant style? This
> should work then in every shell derivate without weird checks.
> 
> This would remove for example function declarations, arrays and so on,
> targeting to the same printable output but with different logic in the
> background.

A quick read:

- remove the word 'function'.
- remove all 'local', ensure names are unique.
- use 'printf '%s' "....." instead of echo -n.

That should be pretty near portable.
Some shells that don't object to the 'local' keyword don't
actually implement local variables!

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)