linux-kernel - [PATCH 0/3] mips: ralink: mt7621: fix kzalloc too early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2022 11:56:55 +1000
From:   John Thomson <git@...nthomson.fastmail.com.au>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        John Crispin <john@...ozen.org>,
        Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 0/3] mips: ralink: mt7621: fix kzalloc too early

ralink mt7621 attempts to use kzalloc before normal memory management is
available.
Before v6.1-rc1, mt7621.c soc_dev_init silently failed to kzalloc and
returned immediately afterwards, continuing to boot without the
SOC_BUS device registered.
After, (with CONFIG_SLUB) kernel crashes before it outputs any console
messages

This was bisected to an mm/slub change (detailed in patch 3)

This change exposed oops in the quirks tables in the mt7621 phy-pci &
pci-controller drivers. The phy-pci quirk fix got into -rc5,
but the pci-controller quirk fix has not been picked up yet.
https://lore.kernel.org/lkml/20221114012036.2870067-1-git@johnthomson.fastmail.com.au/T/#u
This is mentioned in patch 3 as:
not yet applied ("PCI: mt7621: add sentinel to quirks table")

Changes from RFC
https://lore.kernel.org/lkml/20221103050538.1930758-1-git@johnthomson.fastmail.com.au/T/#u
to v1:

1/3:
cut the CPHYSADDR to match the line moved to the header file
2/3:
No useless const unsigned {int,bool} function declarations (thanks
kernel test robot)
3/3:
static struct *soc_info_ptr
Mention fixed phy-pci & (unapplied) pci-controller quirks sentinels
Add fixes tag

Cheers,
John