linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1683603c-8486-b7a7-e9d7-bddd28c1cd8c@collabora.com>
Date:   Mon, 14 Nov 2022 12:02:30 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     matthias.bgg@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
        frank-w@...lic-files.de
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible

Il 11/11/22 12:36, matthias.bgg@...nel.org ha scritto:
> From: Matthias Brugger <mbrugger@...e.com>
> 
> Missing SoC compatible in the board file causes dt bindings check.
> 
> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +-
>   arch/arm64/boot/dts/mediatek/mt7986a.dtsi    | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> index afe37b702eef9..0e3b603159477 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> @@ -9,7 +9,7 @@
>   
>   / {
>   	model = "MediaTek MT7986a RFB";
> -	compatible = "mediatek,mt7986a-rfb";
> +	compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a";
>   
>   	aliases {
>   		serial0 = &uart0;
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> index 72e0d9722e07a..1191ecf345a7d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> @@ -14,6 +14,8 @@ / {
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   
> +	compatible = "mediatek,mt7986a";
> +

It's DTS that shall declare the machine compatible and it's expected that they
all declare their own, so please drop this one.

Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that
one too?

	compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b";

Cheers,
Angelo