linux-kernel - Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cb8207d-e2c1-b459-e456-d8998f8180c8@huawei.com>
Date:   Mon, 14 Nov 2022 19:11:16 +0800
From:   cuigaosheng <cuigaosheng1@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <dinguyen@...nel.org>, <richard.gong@...el.com>,
        <atull@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in
 stratix10_svc_drv_probe()

> How was this found and tested?

Thanks for taking time to review this patch.
I found this through the cocci script, I made the patch based on the code logic,
but I have not tested it due to the lack of hardware devices.

On 2022/11/14 15:24, Greg KH wrote:
> On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote:
>> The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
>> IS_ERR() to check the return value, and return it on failure.
> How was this found and tested?
>
> thanks,
>
> greg k-h
> .