| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221114112438.GA472998@lothringen>
Date: Mon, 14 Nov 2022 12:24:38 +0100
From: Frederic Weisbecker <frederic@...nel.org>
To: Zhen Lei <thunder.leizhen@...wei.com>
Cc: "Paul E . McKenney" <paulmck@...nel.org>,
Neeraj Upadhyay <quic_neeraju@...cinc.com>,
Josh Triplett <josh@...htriplett.org>,
Steven Rostedt <rostedt@...dmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Lai Jiangshan <jiangshanlai@...il.com>,
Joel Fernandes <joel@...lfernandes.org>, rcu@...r.kernel.org,
linux-kernel@...r.kernel.org, Robert Elliott <elliott@....com>
Subject: Re: [PATCH v7 4/6] rcu: Add RCU stall diagnosis information
On Fri, Nov 11, 2022 at 09:07:07PM +0800, Zhen Lei wrote:
> Because RCU CPU stall warnings are driven from the scheduling-clock
> interrupt handler, a workload consisting of a very large number of
> short-duration hardware interrupts can result in misleading stall-warning
> messages. On systems supporting only a single level of interrupts,
> that is, where interrupts handlers cannot be interrupted, this can
> produce misleading diagnostics. The stack traces will show the
> innocent-bystander interrupted task, not the interrupts that are
> at the very least exacerbating the stall.
>
> This situation can be improved by displaying the number of interrupts
> and the CPU time that they have consumed. Diagnosing other types
> of stalls can be eased by also providing the count of softirqs and
> the CPU time that they consumed as well as the number of context
> switches and the task-level CPU time consumed.
>
> Consider the following output given this change:
>
> rcu: INFO: rcu_preempt self-detected stall on CPU
> rcu: 0-....: (1250 ticks this GP) <omitted>
> rcu: hardirqs softirqs csw/system
> rcu: number: 624 45 0
> rcu: cputime: 69 1 2425 ==> 2500(ms)
>
> This output shows that the number of hard and soft interrupts is small,
> there are no context switches, and the system takes up a lot of time. This
> indicates that the current task is looping with preemption disabled.
>
> The impact on system performance is negligible because snapshot is
> recorded only once for all continuous RCU stalls.
>
> This added debugging information is suppressed by default and can be
> enabled by building the kernel with CONFIG_RCU_CPU_STALL_CPUTIME=y or
> by booting with rcupdate.rcu_cpu_stall_cputime=1.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>
> Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> ---
> .../admin-guide/kernel-parameters.txt | 6 ++++
> kernel/rcu/Kconfig.debug | 11 +++++++
> kernel/rcu/rcu.h | 1 +
> kernel/rcu/tree.c | 18 +++++++++++
> kernel/rcu/tree.h | 19 ++++++++++++
> kernel/rcu/tree_stall.h | 31 +++++++++++++++++++
> kernel/rcu/update.c | 2 ++
> 7 files changed, 88 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 811b2e6d4672685..ee7d9d962591c5d 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -5084,6 +5084,12 @@
> rcupdate.rcu_cpu_stall_timeout to be used (after
> conversion from seconds to milliseconds).
>
> + rcupdate.rcu_cpu_stall_cputime= [KNL]
> + Provide statistics on the cputime and count of
> + interrupts and tasks during the sampling period. For
> + multiple continuous RCU stalls, all sampling periods
> + begin at half of the first RCU stall timeout.
> +
> rcupdate.rcu_expedited= [KNL]
> Use expedited grace-period primitives, for
> example, synchronize_rcu_expedited() instead
> diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug
> index 1b0c41d490f0588..025566a9ba44667 100644
> --- a/kernel/rcu/Kconfig.debug
> +++ b/kernel/rcu/Kconfig.debug
> @@ -95,6 +95,17 @@ config RCU_EXP_CPU_STALL_TIMEOUT
> says to use the RCU_CPU_STALL_TIMEOUT value converted from
> seconds to milliseconds.
>
> +config RCU_CPU_STALL_CPUTIME
> + bool "Provide additional RCU stall debug information"
> + depends on RCU_STALL_COMMON
> + default n
> + help
> + Collect statistics during the sampling period, such as the number of
> + (hard interrupts, soft interrupts, task switches) and the cputime of
> + (hard interrupts, soft interrupts, kernel tasks) are added to the
> + RCU stall report. For multiple continuous RCU stalls, all sampling
> + periods begin at half of the first RCU stall timeout.
> +
> config RCU_TRACE
> bool "Enable tracing for RCU"
> depends on DEBUG_KERNEL
> diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h
> index 96122f203187f39..4844dec36bddb48 100644
> --- a/kernel/rcu/rcu.h
> +++ b/kernel/rcu/rcu.h
> @@ -231,6 +231,7 @@ extern int rcu_cpu_stall_ftrace_dump;
> extern int rcu_cpu_stall_suppress;
> extern int rcu_cpu_stall_timeout;
> extern int rcu_exp_cpu_stall_timeout;
> +extern int rcu_cpu_stall_cputime;
> int rcu_jiffies_till_stall_check(void);
> int rcu_exp_jiffies_till_stall_check(void);
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index ed93ddb8203d42c..3921aacfd421ba9 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -866,6 +866,24 @@ static int rcu_implicit_dynticks_qs(struct rcu_data *rdp)
> rdp->rcu_iw_gp_seq = rnp->gp_seq;
> irq_work_queue_on(&rdp->rcu_iw, rdp->cpu);
> }
> +
> + if (rcu_cpu_stall_cputime && rdp->snap_record.gp_seq != rdp->gp_seq) {
> + int cpu = rdp->cpu;
> + struct rcu_snap_record *rsrp;
> + struct kernel_cpustat *kcsp;
> +
> + kcsp = &kcpustat_cpu(cpu);
> +
> + rsrp = &rdp->snap_record;
> + rsrp->cputime_irq = kcpustat_field(kcsp, CPUTIME_IRQ, cpu);
> + rsrp->cputime_softirq = kcpustat_field(kcsp, CPUTIME_SOFTIRQ, cpu);
> + rsrp->cputime_system = kcpustat_field(kcsp, CPUTIME_SYSTEM, cpu);
> + rsrp->nr_hardirqs = kstat_cpu_irqs_sum(rdp->cpu);
> + rsrp->nr_softirqs = kstat_cpu_softirqs_sum(rdp->cpu);
Getting the sum of all CPU's IRQs, with even two iterations on all of them, look
costly. So I have to ask: why is this information useful and why can't we deduce
it from other CPUs stall reports?
I'm also asking because this rcu_cpu_stall_cputime is likely to be very useful for
distros, to the point that I expect it to be turned on by default as doing a
snapshot of kcpustat fields is cheap. But doing that wide CPU snapshot is
definetly going to be an unbearable overhead.
Thanks.
Powered by blists - more mailing lists