linux-kernel - Re: [PATCH 10/10] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf66aa8f-4bf7-d9c0-e2ae-b6fced7e4948@linaro.org>
Date:   Mon, 14 Nov 2022 11:40:50 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Banajit Goswami <bgoswami@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Patrick Lai <plai@....qualcomm.com>,
        Srinivasa Rao Mandadapu <srivasam@....qualcomm.com>
Subject: Re: [PATCH 10/10] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais
 node



On 11/11/2022 11:35, Krzysztof Kozlowski wrote:
> On SM8450 and SC8280XP, the Q6APM is a bit different:

This is not specific to SM8450 or SC8280XP its part of AudioReach apm 
which deals with both backends and pcm.

In old Elite architecture we had a dedicated service AFE to deal with 
Backend dais, now APM does all.

Thanks,
Srini

> 1. It is used as a platform DAI link, so it needs #sound-dai-cells.
> 2. It has two DAI children, so add new "bedais" node.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   .../devicetree/bindings/sound/qcom,q6apm.yaml    | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> index 7acb832aa557..cd434e8268ce 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
> @@ -18,14 +18,24 @@ properties:
>       enum:
>         - qcom,q6apm
>   
> +  bedais:
> +    type: object
> +    $ref: /schemas/sound/qcom,q6apm-lpass-dais.yaml#
> +    unevaluatedProperties: false
> +    description: Qualcomm DSP audio ports
> +
>     dais:
>       type: object
>       $ref: /schemas/sound/qcom,q6apm-dai.yaml#
>       unevaluatedProperties: false
>       description: Qualcomm DSP audio ports
>   
> +  '#sound-dai-cells':
> +    const: 0
> +
>   required:
>     - compatible
> +  - bedais
>     - dais
>   
>   unevaluatedProperties: false
> @@ -41,11 +51,17 @@ examples:
>           service@1 {
>               reg = <GPR_APM_MODULE_IID>;
>               compatible = "qcom,q6apm";
> +            #sound-dai-cells = <0>;
>               qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>   
>               dais {
>                   compatible = "qcom,q6apm-dais";
>                   iommus = <&apps_smmu 0x1801 0x0>;
>               };
> +
> +            bedais {
> +                compatible = "qcom,q6apm-lpass-dais";
> +                #sound-dai-cells = <1>;
> +            };
>           };
>       };