| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <64ffce75-e64e-91ad-162f-c1c7c4c9d472@nvidia.com>
Date: Mon, 14 Nov 2022 12:01:12 +0000
From: Wayne Chang <waynec@...dia.com>
To: Jonathan Hunter <jonathanh@...dia.com>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
Thierry Reding <treding@...dia.com>,
"thierry.reding@...il.com" <thierry.reding@...il.com>,
"heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
Ajay Gupta <ajayg@...dia.com>,
"vkoul@...nel.org" <vkoul@...nel.org>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"balbi@...nel.org" <balbi@...nel.org>,
"mathias.nyman@...el.com" <mathias.nyman@...el.com>,
Jui Chang Kuo <jckuo@...dia.com>
CC: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Sing-Han Chen <singhanc@...dia.com>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v2 03/13] dt-bindings: usb: Add binding for Cypress
cypd4226 I2C driver
On 11/11/22 22:36, Jon Hunter wrote:
>
> On 11/11/2022 10:14, Wayne Chang wrote:
>> add device-tree binding documentation for Cypress cypd4226 type-C
>> controller's I2C interface. It is a standard I2C slave with GPIO
>> input as IRQ interface.
>>
>> Signed-off-by: Wayne Chang <waynec@...dia.com>
>> ---
>> V1 -> V2:Based on the review comments. Fix some addressed issues on
>> description, interrupts, cypress,firmware-build, connector, and
>> additionalProperties properties. And also remove the status in the
>> example.
>> .../bindings/usb/cypress,cypd4226.yaml | 86 +++++++++++++++++++
>> 1 file changed, 86 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>> b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>> new file mode 100644
>> index 000000000000..70db97e0ad31
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>> @@ -0,0 +1,86 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/usb/cypress,cypd4226.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Cypress cypd4226 UCSI I2C Type-C Controller
>> +
>> +maintainers:
>> + - Wayne Chang <waynec@...dia.com>
>> +
>> +description:
>> + The Cypress cypd4226 UCSI I2C type-C controller is a I2C interface
>> type-C
>> + controller.
>> +
>> +properties:
>> + compatible:
>> + const: cypress,cypd4226
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>> +
>> + reg:
>> + const: 0x08
>> +
>> + interrupts:
>> + items:
>> + - description: cypd4226 I2C interrupt
>> +
>> + cypress,firmware-build:
>> + enum:
>> + - nvidia,gpu
>> + - nvidia,jetson-agx-xavier
>> + description: |
>> + the name of the CCGx firmware built for product series.
>> + should be set one of following:
>> + - "nvidia,gpu" for the NVIDIA RTX product series
>> + - "nvidia,jetson-agx-xavier" for the NVIDIA Jetson product series
>> +
>> +patternProperties:
>> + '^connector@[0-1]+$':
>> + $ref: /schemas/connector/usb-connector.yaml#
>> + properties:
>> + reg:
>> + maxItems: 1
>> +
>> +unevaluatedProperties: false
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/tegra194-gpio.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + #interrupt-cells = <2>;
>> +
>> + ucsi-ccg@8 {
>> + compatible = "cypress,cypd4226";
>> + interrupt-parent = <&gpio_aon>;
>> + interrupts = <TEGRA194_AON_GPIO(BB, 2) IRQ_TYPE_LEVEL_LOW>;
>> + reg = <0x08>;
>> + cypress,firmware-build = "nvidia,jetson-agx-xavier";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + ccg_typec_con0: connector@0 {
>> + compatible = "usb-c-connector";
>> + reg = <0>;
>> + label = "USB-C";
>> + data-role = "dual";
>> + port {
>> + ucsi_ccg_p0: endpoint {
>> + remote-endpoint = <&usb_role_switch0>;
>> + };
>> + };
>> + };
>> + };
>> + };
>
>
> I see warnings with this change ...
>
> Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml:
> 'additionalProperties' is a required property
> hint: A schema without a "$ref" to another schema must define all
> properties and use "additionalProperties"
> from schema $id: http://devicetree.org/meta-schemas/base.yaml#
>
>
> Looking at Rob's comments I believe we need ...
>
> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> index 70db97e0ad31..8feafbaf9e20 100644
> --- a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> @@ -43,17 +43,19 @@ properties:
> patternProperties:
> '^connector@[0-1]+$':
> $ref: /schemas/connector/usb-connector.yaml#
> + unevaluatedProperties: false
> properties:
> reg:
> maxItems: 1
>
> -unevaluatedProperties: false
>
> required:
> - compatible
> - reg
> - interrupts
>
> +additionalProperties: false
> +
>
Thanks for the review.
Somehow I do not get the warnings in local test.
I'll apply the change into the next patch series.
thanks,
Wayne.
Powered by blists - more mailing lists