linux-kernel - Re: [PATCH 06/18] mfd: max77650: Remove useless type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McQCrYEo729k9cnH_bB0Vt5BSB1OHg0tsA3rBL51EdUKA@mail.gmail.com>
Date:   Mon, 14 Nov 2022 13:24:27 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>
Cc:     lee@...nel.org, mani@...nel.org, cristian.ciocaltea@...il.com,
        wens@...e.org, tharvey@...eworks.com, cw00.choi@...sung.com,
        krzysztof.kozlowski@...aro.org, mazziesaccount@...il.com,
        orsonzhai@...il.com, baolin.wang@...ux.alibaba.com,
        zhang.lyra@...il.com, jernej.skrabec@...il.com,
        samuel@...lland.org, linux-kernel@...r.kernel.org,
        linux-actions@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 06/18] mfd: max77650: Remove useless type_invert flag

On Sat, Nov 12, 2022 at 4:19 PM Aidan MacDonald
<aidanmacdonald.0x0@...il.com> wrote:
>
> The type_invert flag does nothing when type_in_mask is set, and
> it's part of deprecated functionality in regmap-irq. Remove it.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> ---
>  drivers/mfd/max77650.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/max77650.c b/drivers/mfd/max77650.c
> index 777485a33bc0..3c07fcdd9d07 100644
> --- a/drivers/mfd/max77650.c
> +++ b/drivers/mfd/max77650.c
> @@ -138,7 +138,6 @@ static const struct regmap_irq_chip max77650_irq_chip = {
>         .status_base            = MAX77650_REG_INT_GLBL,
>         .mask_base              = MAX77650_REG_INTM_GLBL,
>         .type_in_mask           = true,
> -       .type_invert            = true,
>         .init_ack_masked        = true,
>         .clear_on_unmask        = true,
>  };
> --
> 2.38.1
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>