linux-kernel - Re: [PATCH] staging: media: omap4iss: correct cacheflush import

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Nov 2022 16:06:50 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Ian Cowan <ian@...ux.cowan.aero>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: omap4iss: correct cacheflush import

Hi Ian,

Thank you for the patch.

On Sat, Nov 12, 2022 at 07:33:47PM -0500, Ian Cowan wrote:
> Correct the import for cacheflush from the asm directory to the linux
> directory.

Unless I'm mistaken, it looks like the header is actually not needed at
all.

> Signed-off-by: Ian Cowan <ian@...ux.cowan.aero>
> ---
>  drivers/staging/media/omap4iss/iss_video.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
> index 842509dcfedf..9f08dd976a24 100644
> --- a/drivers/staging/media/omap4iss/iss_video.c
> +++ b/drivers/staging/media/omap4iss/iss_video.c
> @@ -7,6 +7,7 @@
>   * Author: Sergio Aguirre <sergio.a.aguirre@...il.com>
>   */
>  
> +#include <linux/cacheflush.h>
>  #include <linux/clk.h>
>  #include <linux/mm.h>
>  #include <linux/pagemap.h>
> @@ -19,8 +20,6 @@
>  #include <media/v4l2-ioctl.h>
>  #include <media/v4l2-mc.h>
>  
> -#include <asm/cacheflush.h>
> -
>  #include "iss_video.h"
>  #include "iss.h"
>  

-- 
Regards,

Laurent Pinchart