linux-kernel - Re: [PATCH 1/1] HID: Send SwID in GetProtocolVersion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e77ba98322873ba8790d4fb7904c844db2d085d.camel@hadess.net>
Date:   Mon, 14 Nov 2022 15:19:09 +0100
From:   Bastien Nocera <hadess@...ess.net>
To:     Andreas Bergmeier <abergmeier@....net>, lains@...eup.net,
        jikos@...nel.org, benjamin.tissoires@...hat.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] HID: Send SwID in GetProtocolVersion

On Fri, 2022-11-11 at 20:45 +0100, Andreas Bergmeier wrote:
> According to docs a SwID should be sent for GetProtocolVersion.
> > 0x10.DeviceIndex.0x00.0x1n
> where n is SwID

I would mention the value of CMD_ROOT_GET_PROTOCOL_VERSION (0x10) in
the commit message, but otherwise looks good to me.

Reviewed-by: Bastien Nocera <hadess@...ess.net>

> 
> Signed-off-by: Andreas Bergmeier <abergmeier@....net>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index a0c148a8df6c..964a523c3de7 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -896,7 +896,7 @@ static int hidpp_root_get_protocol_version(struct
> hidpp_device *hidpp)
> 
>         ret = hidpp_send_rap_command_sync(hidpp,
>                         HIDPP_PAGE_ROOT_IDX,
> -                       CMD_ROOT_GET_PROTOCOL_VERSION,
> +                       CMD_ROOT_GET_PROTOCOL_VERSION |
> LINUX_KERNEL_SW_ID,
>                         ping_data, sizeof(ping_data), &response);
> 
>         if (ret == HIDPP_ERROR_INVALID_SUBID) {
> --
> 2.34.1
>