linux-kernel - [PATCH] mm: shrinkers: Add missing includes for undeclared types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221114235949.201749-1-tjmercier@google.com>
Date:   Mon, 14 Nov 2022 23:59:49 +0000
From:   "T.J. Mercier" <tjmercier@...gle.com>
To:     android-mm@...gle.com,
        Konstantin Khlebnikov <khlebnikov@...nvz.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dave Chinner <dchinner@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>
Cc:     "T.J. Mercier" <tjmercier@...gle.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] mm: shrinkers: Add missing includes for undeclared types

The shrinker.h header depends on a user including other headers before
it for types used by shrinker.h. Fix this by including the appropriate
headers in shrinker.h.

./include/linux/shrinker.h:13:9: error: unknown type name ‘gfp_t’
   13 |         gfp_t gfp_mask;
      |         ^~~~~
./include/linux/shrinker.h:71:26: error: field ‘list’ has incomplete type
   71 |         struct list_head list;
      |                          ^~~~
./include/linux/shrinker.h:82:9: error: unknown type name ‘atomic_long_t’
   82 |         atomic_long_t *nr_deferred;
      |

Fixes: 83aeeada7c69 ("vmscan: use atomic-long for shrinker batching")
Fixes: b0d40c92adaf ("superblock: introduce per-sb cache shrinker infrastructure")
Signed-off-by: T.J. Mercier <tjmercier@...gle.com>
---
 include/linux/shrinker.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h
index 08e6054e061f..71310efe2fab 100644
--- a/include/linux/shrinker.h
+++ b/include/linux/shrinker.h
@@ -2,6 +2,9 @@
 #ifndef _LINUX_SHRINKER_H
 #define _LINUX_SHRINKER_H
 
+#include <linux/atomic.h>
+#include <linux/types.h>
+
 /*
  * This struct is used to pass information from page reclaim to the shrinkers.
  * We consolidate the values for easier extension later.
-- 
2.38.1.493.g58b659f92b-goog