[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y3PF9k8/ofe8EatQ@chromium.org>
Date: Tue, 15 Nov 2022 10:01:42 -0700
From: Jack Rosenthal <jrosenth@...omium.org>
To: Peng Wu <wupeng58@...wei.com>
Cc: jwerner@...omium.org, gregkh@...uxfoundation.org,
groeck@...omium.org, linux-kernel@...r.kernel.org,
liwei391@...wei.com
Subject: Re: [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in
cbmem_entry_probe()
On 2022-11-15 at 09:11 +0000, Peng Wu wrote:
> The devm_memremap() function returns error pointers on error,
> it doesn't return NULL.
>
> Fixes: 19d54020883c ("firmware: google: Implement cbmem in sysfs driver")
> Signed-off-by: Peng Wu <wupeng58@...wei.com>
Reviewed-by: Jack Rosenthal <jrosenth@...omium.org>
> ---
> drivers/firmware/google/cbmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/google/cbmem.c
> index 685f3070ce9d..88e587ba1e0d 100644
> --- a/drivers/firmware/google/cbmem.c
> +++ b/drivers/firmware/google/cbmem.c
> @@ -106,8 +106,8 @@ static int cbmem_entry_probe(struct coreboot_device *dev)
> entry->mem_file_buf = devm_memremap(&dev->dev, dev->cbmem_entry.address,
> dev->cbmem_entry.entry_size,
> MEMREMAP_WB);
> - if (!entry->mem_file_buf)
> - return -ENOMEM;
> + if (IS_ERR(entry->mem_file_buf))
> + return PTR_ERR(entry->mem_file_buf);
>
> entry->size = dev->cbmem_entry.entry_size;
>
> --
> 2.17.1
>
Powered by blists - more mailing lists