linux-kernel - Re: [PATCH] cxgb4i : Added pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94a9621d-f526-cd70-64fd-1c519cf1bcf1@oracle.com>
Date:   Tue, 15 Nov 2022 11:30:03 -0600
From:   Mike Christie <michael.christie@...cle.com>
To:     Denis Arefev <arefev@...mel.ru>, Karen Xie <kxie@...lsio.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        ldv-project@...uxtesting.org, trufanov@...mel.ru, vfh@...mel.ru
Subject: Re: [PATCH] cxgb4i : Added pointer check

On 11/15/22 3:46 AM, Denis Arefev wrote:
> Return value of a function 'alloc_wr' is dereferenced at cxgb4i.c:624
> without checking for null, but it is usually checked for this function
> 
> Signed-off-by: Denis Arefev <arefev@...mel.ru>
> ---
>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> index 2c3491528d42..40ed8e27945c 100644
> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> @@ -611,7 +611,7 @@ static inline int tx_flowc_wr_credits(int *nparamsp, int *flowclenp)
>  
>  static inline int send_tx_flowc_wr(struct cxgbi_sock *csk)
>  {
> -	struct sk_buff *skb;
> +	struct sk_buff *skb = NULL;

You can drop this part since it's set a little lower when we do the alloc.

>  	struct fw_flowc_wr *flowc;
>  	int nparams, flowclen16, flowclen;
>  
> @@ -620,6 +620,8 @@ static inline int send_tx_flowc_wr(struct cxgbi_sock *csk)
>  #endif
>  	flowclen16 = tx_flowc_wr_credits(&nparams, &flowclen);
>  	skb = alloc_wr(flowclen, 0, GFP_ATOMIC);
> +	if (!skb)
> +	 return -ENOMEM;

Your tabbing got messed up. Maybe you used a space where you wanted a tab.


>  	flowc = (struct fw_flowc_wr *)skb->head;
>  	flowc->op_to_nparams =
>  		htonl(FW_WR_OP_V(FW_FLOWC_WR) | FW_FLOWC_WR_NPARAMS_V(nparams));