linux-kernel - Re: [PATCH v3] scripts/gdb: add lx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221115180635.crej6pcvokdo3njy@kamzik>
Date:   Tue, 15 Nov 2022 19:06:35 +0100
From:   Andrew Jones <ajones@...tanamicro.com>
To:     Deepak Gupta <debug@...osinc.com>
Cc:     Conor Dooley <conor.dooley@...rochip.com>, aou@...s.berkeley.edu,
        jan.kiszka@...mens.com, kbingham@...nel.org,
        linux-kernel@...r.kernel.org, palmer@...belt.com,
        paul.walmsley@...ive.com, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v3] scripts/gdb: add lx_current support for riscv

On Tue, Nov 15, 2022 at 09:49:10AM -0800, Deepak Gupta wrote:
...
> On Tue, Nov 15, 2022 at 6:38 AM Conor Dooley <conor.dooley@...rochip.com>
> wrote:
> 
> > Hey Deepak,
> >
> > On Tue, Nov 15, 2022 at 12:49:23AM -0800, Deepak Gupta wrote:
...
> > > +         if (scratch_reg.cast(utils.get_ulong_type()) >
> > current_tp.cast(utils.get_ulong_type())):
> >                                                           ^^
> > extra space here?
> 
> 
> I don't see the space in the patch. Can you clarify which space you're
> talking about here?

The same one I pointed out in v2. The one after the greater-than sign.
Is your editor not using a monospaced font?

Thanks,
drew