linux-kernel - Re: [PATCH] coredump: Fix build error for ‘dump_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2022 19:35:03 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Li Hua <hucool.lihua@...wei.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>
CC:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "weiyongjun1@...wei.com" <weiyongjun1@...wei.com>,
        "yusongping@...wei.com" <yusongping@...wei.com>
Subject: Re: [PATCH] coredump: Fix build error for ‘dump_emit_page’ defined but not used

On 11/14/22 20:04, Li Hua wrote:
> If CONFIG_ELF_CORE is not set:
>      fs/coredump.c:834:12: error: ‘dump_emit_page’ defined but not used [-Werror=unused-function]
>      static int dump_emit_page(struct coredump_params *cprm, struct page *page)
>              ^~~~~~~~~~~~~~
> 
> Fix this by adding the missing CONFIG_ELF_CORE for dump_emit_page.
> 
> Fixes: 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
> Signed-off-by: Li Hua <hucool.lihua@...wei.com>
> ---


Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck