linux-kernel - Re: [PATCH bpf-next v2] bpftool: Check argc first before "file" in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACdoK4KEzd8w3pWjuGet-W3ZzAf+8uBpzngk_aX7_aBDYm4T5Q@mail.gmail.com>
Date:   Tue, 15 Nov 2022 20:19:05 +0000
From:   Quentin Monnet <quentin@...valent.com>
To:     sdf@...gle.com
Cc:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v2] bpftool: Check argc first before "file" in do_batch()

On Tue, 15 Nov 2022 at 18:42, <sdf@...gle.com> wrote:
>
> On 11/15, Tiezhu Yang wrote:
> > If the parameters for batch are more than 2, check argc first can
> > return immediately, no need to use is_prefix() to check "file" with
> > a little overhead and then check argc, it is better to check "file"
> > only when the parameters for batch are 2.
>
> > Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
>
> Acked-by: Stanislav Fomichev <sdf@...gle.com>

Reviewed-by: Quentin Monnet <quentin@...valent.com>

Thanks