linux-kernel - Re: [V3 PATCH 1/4] KVM: selftests: move common startup logic to kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMkAt6rEWm3x3nqcss4R9Dzar55=P6EazmD0J-kq+HEs5qT9QQ@mail.gmail.com>
Date:   Tue, 15 Nov 2022 14:03:39 -0700
From:   Peter Gonda <pgonda@...gle.com>
To:     Vishal Annapurve <vannapurve@...gle.com>
Cc:     x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, pbonzini@...hat.com,
        shuah@...nel.org, bgardon@...gle.com, seanjc@...gle.com,
        oupton@...gle.com, peterx@...hat.com, vkuznets@...hat.com,
        dmatlack@...gle.com, Andrew Jones <andrew.jones@...ux.dev>
Subject: Re: [V3 PATCH 1/4] KVM: selftests: move common startup logic to kvm_util.c

On Thu, Oct 13, 2022 at 6:13 AM Vishal Annapurve <vannapurve@...gle.com> wrote:
>
> Consolidate common startup logic in one place by implementing a single
> setup function with __attribute((constructor)) for all selftests within
> kvm_util.c.
>
> This allows moving logic like:
>         /* Tell stdout not to buffer its content */
>         setbuf(stdout, NULL);
> to a single file for all selftests.
>
> This will also allow any required setup at entry in future to be done in
> common main function.
>
> More context is discussed at:
> https://lore.kernel.org/lkml/Ywa9T+jKUpaHLu%2Fl@google.com/
>
> Suggested-by: Sean Christopherson <seanjc@...gle.com>
> Signed-off-by: Vishal Annapurve <vannapurve@...gle.com>
> Reviewed-by: Andrew Jones <andrew.jones@...ux.dev>

Reviewed-by: Peter Gonda <pgonda@...gle.com>