[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3QDIVy0c01Tie3L@bombadil.infradead.org>
Date: Tue, 15 Nov 2022 13:22:41 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Nick Alcock <nick.alcock@...cle.com>
Cc: masahiroy@...nel.org, linux-modules@...r.kernel.org,
linux-kernel@...r.kernel.org, arnd@...db.de,
akpm@...ux-foundation.org, eugene.loh@...cle.com,
kris.van.hees@...cle.com, thunder.leizhen@...wei.com,
Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v9 3/8] kbuild: generate an address ranges map at vmlinux
link time
On Mon, Nov 14, 2022 at 04:48:57PM +0000, Nick Alcock wrote:
> [Added Steve Rostedt to Cc:]
>
> On 13 Nov 2022, Luis Chamberlain stated:
>
> > On Wed, Nov 09, 2022 at 01:41:27PM +0000, Nick Alcock wrote:
> >> This emits a new file, .tmp_vmlinux.ranges, which maps address
> >> range/size pairs in vmlinux to the object files which make them up,
> >> e.g., in part:
> >>
> >> 0x0000000000000000 0x30 arch/x86/kernel/cpu/common.o
> >> 0x0000000000001000 0x1000 arch/x86/events/intel/ds.o
> >> 0x0000000000002000 0x4000 arch/x86/kernel/irq_64.o
> >> 0x0000000000006000 0x5000 arch/x86/kernel/process.o
> >> 0x000000000000b000 0x1000 arch/x86/kernel/cpu/common.o
> >> 0x000000000000c000 0x5000 arch/x86/mm/cpu_entry_area.o
> >> 0x0000000000011000 0x10 arch/x86/kernel/espfix_64.o
> >> 0x0000000000011010 0x2 arch/x86/kernel/cpu/common.o
> >> [...]
> >
> > This does't say why we'd want this. So either you merge it with its
> > first user or you explain here why anyone might find this useful.
>
> Uh... the first user is later in this patch series? If you want each
> commit to have a self-contained explanation, I could certainly note why
> it's useful for said first user in this commit message (and adjust other
> messages similarly), but I had previous complaints that commit log
> messages and the cover letter were repeating points, so I was trying to
> reduce that kind of thing.
Commit logs should be self contained. The reason for *why* we want to
add ranges should go here, not the cover letter. You can be terse in the
cover letter over the general solution.
Luis
Powered by blists - more mailing lists