linux-kernel - Re: [PATCH] usb: fotg210-udc: Remove a useless assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY4+FtRc63GY_A2Gwr-cstMfsMvojHmQ_o2UQP0ymasig@mail.gmail.com>
Date:   Tue, 15 Nov 2022 22:42:02 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: fotg210-udc: Remove a useless assignment

On Mon, Nov 14, 2022 at 9:38 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:

> There is no need to use an intermediate array for these memory allocations,
> so, axe it.
>
> While at it, turn a '== NULL' into a shorter '!' when testing memory
> allocation failure.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Fair enough!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I have sent some other cleanups to this code only
yesterday, so they might collide and they you might have
to rebase.

Yours,
Linus Walleij