linux-kernel - Re: [PATCH] cacheinfo: Decrement refcount in cache_setup_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20ab3aba-0f19-a5a5-1fe6-16f579879c28@arm.com>
Date:   Tue, 15 Nov 2022 23:10:19 +0100
From:   Pierre Gondois <pierre.gondois@....com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-kernel@...r.kernel.org, Rob.Herring@....com,
        sudeep.holla@....com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] cacheinfo: Decrement refcount in cache_setup_of_node()



On 11/15/22 20:30, Marek Szyprowski wrote:
> Hi Geert,
> 
> On 15.11.2022 14:06, Geert Uytterhoeven wrote:
>> On Wed, Oct 26, 2022 at 9:03 PM Pierre Gondois <pierre.gondois@....com> wrote:
>>> Refcounts to DT nodes are only incremented in the function
>>> and never decremented. Decrease the refcounts when necessary.
>>>
>>> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
>> Thanks for your patch, which is now commit 3da72e18371c41a6
>> ("cacheinfo: Decrement refcount in cache_setup_of_node()") in
>> driver-core-next.
>>
>> I have bisected a refcount underflow during s2ram to this commit:
> 
> Similar issue can be reproduced with qemu/arm64 'virt' machine during boot:
> 

Hello Geert, Marek,

Thanks for reporting the issue. The patch at:
https://lore.kernel.org/all/20221115220520.2076189-1-pierre.gondois@arm.com/
should fix it,

Regards,
Pierre