linux-kernel - Re: [PATCH] dmaengine: ste_dma40: add missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbeCqb6v==ygtTHpiUXpfsYbmOKwvXH39k-GUgWtbqFEg@mail.gmail.com>
Date:   Tue, 15 Nov 2022 23:12:58 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     ruanjinjie <ruanjinjie@...wei.com>
Cc:     vkoul@...nel.org, linux-arm-kernel@...ts.infradead.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ste_dma40: add missing free_irq() in error path

On Tue, Nov 15, 2022 at 9:19 AM ruanjinjie <ruanjinjie@...wei.com> wrote:

> free_irq() is missing in some cases of error in d40_probe(), fix that.
>
> Signed-off-by: ruanjinjie <ruanjinjie@...wei.com>

Correct, but ... please just convert it to use
devm_request_irq() instead. Less lines of code.

Yours,
Linus Walleij