linux-kernel - Re: [PATCH] scripts: subarch.include: fix SUBARCH on MacOS hosts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y3MRvtwdjIwMHvRo@bergen.fjasle.eu>
Date:   Tue, 15 Nov 2022 05:12:46 +0100
From:   Nicolas Schier <nicolas@...sle.eu>
To:     Nick Desaulniers <nick.desaulniers@...il.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <git@...0n.name>, Guo Ren <guoren@...nel.org>,
        linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
        asahi@...ts.linux.dev, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] scripts: subarch.include: fix SUBARCH on MacOS hosts

On Sun, 13 Nov 2022 15:38:09 -0800 Nick Desaulniers wrote:
> When building the Linux kernel on an aarch64 MacOS based host, if we don't
> specify a value for ARCH when invoking make, we default to arm and thus
> multi_v7_defconfig rather than the expected arm64 and arm64's defconfig.
> 
> This is because subarch.include invokes `uname -m` which on MacOS hosts
> evaluates to `arm64` but on Linux hosts evaluates to `aarch64`,
> 
> This allows us to build ARCH=arm64 natively on MacOS (as in ARCH need
> not be specified on an aarch64-based system).
> 
> Utilize a negative lookahead regular expression to avoid matching arm64.
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@...il.com>
> ---
> This is only part 1 of
> https://github.com/ClangBuiltLinux/linux/commit/f06333e29addbc3d714adb340355f471c1dfe95a
> I'm still working on the rest...
> 
>  scripts/subarch.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/subarch.include b/scripts/subarch.include
> index 4bd327d0ae42..aa130286b627 100644
> --- a/scripts/subarch.include
> +++ b/scripts/subarch.include
> @@ -6,7 +6,7 @@
>  
>  SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
>  				  -e s/sun4u/sparc64/ \
> -				  -e s/arm.*/arm/ -e s/sa110/arm/ \
> +				  -e s/arm\(?:\(?!64\).*\)/arm/ -e s/sa110/arm/ \

On my Debian's sed, this does not match any more at all, e.g.:

  $ echo armv4 | sed -e 's/arm\(?:\(?!64\).*\)/arm/'
  armv4
.

This one works for me, but does not look such advanced:

  $ echo arm64 | sed -e '/^arm64$/!s/arm.*/arm/'
  arm64
  $ echo armv4 | sed -e '/^arm64$/!s/arm.*/arm/'
  arm
.

Kind regards,
Nicolas

>  				  -e s/s390x/s390/ \
>  				  -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
>  				  -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
> -- 
> 2.37.0 (Apple Git-136)

-- 
epost|xmpp: nicolas@...sle.eu          irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
     -- frykten for herren er opphav til kunnskap --

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)