linux-kernel - RE: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_core_sta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d97dc8a2b3447e998861ab6b8fb74af@realtek.com>
Date:   Tue, 15 Nov 2022 00:30:55 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc()



> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Sent: Sunday, November 13, 2022 11:49 PM
> To: Ping-Ke Shih <pkshih@...ltek.com>; Kalle Valo <kvalo@...nel.org>; David S. Miller <davem@...emloft.net>;
> Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>
> Cc: linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org; Christophe JAILLET
> <christophe.jaillet@...adoo.fr>; linux-wireless@...r.kernel.org; netdev@...r.kernel.org
> Subject: [PATCH] wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc()
> 
> 'ret' is not updated after a function call in rtw89_core_sta_assoc().
> This prevent error handling from working.
> 
> Add the missing assignment.
> 
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
> index e716b96d0f56..f30aadc41f2b 100644
> --- a/drivers/net/wireless/realtek/rtw89/core.c
> +++ b/drivers/net/wireless/realtek/rtw89/core.c
> @@ -2535,7 +2535,7 @@ int rtw89_core_sta_assoc(struct rtw89_dev *rtwdev,
>  	}
> 
>  	/* update cam aid mac_id net_type */
> -	rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL);
> +	ret = rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL);
>  	if (ret) {
>  		rtw89_warn(rtwdev, "failed to send h2c cam\n");
>  		return ret;
> --
> 2.34.1