linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7280: Make herobrine-audio-rt5682 mic dtsi's match more

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a724efdc-f35a-8320-f2e1-0078198408d4@linaro.org>
Date:   Tue, 15 Nov 2022 01:35:06 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Douglas Anderson <dianders@...omium.org>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     mka@...omium.org, swboyd@...omium.org,
        Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>,
        judyhsiao@...omium.org, Andy Gross <agross@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Make herobrine-audio-rt5682 mic
 dtsi's match more


On 15/11/2022 01:28, Douglas Anderson wrote:
> The 1-mic and 3-mic dtsi still had two minor cosmetic differences
> after commit 3d11e7e120ee ("arm64: dts: qcom: sc7280: sort out the
> "Status" to last property with
> sc7280-herobrine-audio-rt5682.dtsi"). Let's fix them so the two files
> diff better. This is expected to have no effect though it will
> slightly change the generated dtb by removing an unnecessary 'status =
> "okay"' from the sound node.

Also known as "no functional change"!


Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>


Konrad

>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
>
>   arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> index fc7a659dfe4a..af685bc35e10 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -19,8 +19,6 @@ sound: sound {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> -		status = "okay";
> -
>   		dai-link@0 {
>   			link-name = "MAX98360";
>   			reg = <0>;
> @@ -96,6 +94,8 @@ dai-link@1 {
>   	};
>   };
>   
> +/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
> +
>   &mi2s0_data0 {
>   	drive-strength = <6>;
>   	bias-disable;