linux-kernel - Re: [PATCH v2] PCI: mvebu: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202211151503.HLlq2Z4B-lkp@intel.com>
Date:   Tue, 15 Nov 2022 15:07:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Pali Rohár <pali@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <helgaas@...nel.org>, linux-pci@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: mvebu: switch to using gpiod API

Hi Dmitry,

I love your patch! Yet something to improve:

[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on helgaas-pci/for-linus linus/master v6.1-rc5 next-20221114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Torokhov/PCI-mvebu-switch-to-using-gpiod-API/20221115-035019
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link:    https://lore.kernel.org/r/Y3KbhIi4ZsSO7%2BCl%40google.com
patch subject: [PATCH v2] PCI: mvebu: switch to using gpiod API
config: arm-defconfig
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ee8de8ec5155d29f3f8e129dfaedd23b87b11a13
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Dmitry-Torokhov/PCI-mvebu-switch-to-using-gpiod-API/20221115-035019
        git checkout ee8de8ec5155d29f3f8e129dfaedd23b87b11a13
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/pci/controller/pci-mvebu.c: In function 'mvebu_pcie_irq_handler':
>> drivers/pci/controller/pci-mvebu.c:1101:9: error: implicit declaration of function 'chained_irq_enter'; did you mean 'ct_irq_enter'? [-Werror=implicit-function-declaration]
    1101 |         chained_irq_enter(chip, desc);
         |         ^~~~~~~~~~~~~~~~~
         |         ct_irq_enter
>> drivers/pci/controller/pci-mvebu.c:1116:9: error: implicit declaration of function 'chained_irq_exit'; did you mean 'ct_irq_exit'? [-Werror=implicit-function-declaration]
    1116 |         chained_irq_exit(chip, desc);
         |         ^~~~~~~~~~~~~~~~
         |         ct_irq_exit
   cc1: some warnings being treated as errors


vim +1101 drivers/pci/controller/pci-mvebu.c

ec075262648f39 Pali Rohár 2022-02-22  1092  
ec075262648f39 Pali Rohár 2022-02-22  1093  static void mvebu_pcie_irq_handler(struct irq_desc *desc)
ec075262648f39 Pali Rohár 2022-02-22  1094  {
ec075262648f39 Pali Rohár 2022-02-22  1095  	struct mvebu_pcie_port *port = irq_desc_get_handler_data(desc);
ec075262648f39 Pali Rohár 2022-02-22  1096  	struct irq_chip *chip = irq_desc_get_chip(desc);
ec075262648f39 Pali Rohár 2022-02-22  1097  	struct device *dev = &port->pcie->pdev->dev;
ec075262648f39 Pali Rohár 2022-02-22  1098  	u32 cause, unmask, status;
ec075262648f39 Pali Rohár 2022-02-22  1099  	int i;
ec075262648f39 Pali Rohár 2022-02-22  1100  
ec075262648f39 Pali Rohár 2022-02-22 @1101  	chained_irq_enter(chip, desc);
ec075262648f39 Pali Rohár 2022-02-22  1102  
ec075262648f39 Pali Rohár 2022-02-22  1103  	cause = mvebu_readl(port, PCIE_INT_CAUSE_OFF);
ec075262648f39 Pali Rohár 2022-02-22  1104  	unmask = mvebu_readl(port, PCIE_INT_UNMASK_OFF);
ec075262648f39 Pali Rohár 2022-02-22  1105  	status = cause & unmask;
ec075262648f39 Pali Rohár 2022-02-22  1106  
ec075262648f39 Pali Rohár 2022-02-22  1107  	/* Process legacy INTx interrupts */
ec075262648f39 Pali Rohár 2022-02-22  1108  	for (i = 0; i < PCI_NUM_INTX; i++) {
ec075262648f39 Pali Rohár 2022-02-22  1109  		if (!(status & PCIE_INT_INTX(i)))
ec075262648f39 Pali Rohár 2022-02-22  1110  			continue;
ec075262648f39 Pali Rohár 2022-02-22  1111  
ec075262648f39 Pali Rohár 2022-02-22  1112  		if (generic_handle_domain_irq(port->intx_irq_domain, i) == -EINVAL)
ec075262648f39 Pali Rohár 2022-02-22  1113  			dev_err_ratelimited(dev, "unexpected INT%c IRQ\n", (char)i+'A');
ec075262648f39 Pali Rohár 2022-02-22  1114  	}
ec075262648f39 Pali Rohár 2022-02-22  1115  
ec075262648f39 Pali Rohár 2022-02-22 @1116  	chained_irq_exit(chip, desc);
ec075262648f39 Pali Rohár 2022-02-22  1117  }
ec075262648f39 Pali Rohár 2022-02-22  1118  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (262518 bytes)