[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6f3a8e24-ab1a-afe3-e907-22d1096a9f53@linaro.org>
Date: Tue, 15 Nov 2022 09:15:21 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Robert Marko <robimarko@...il.com>, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: net: ipq4019-mdio: require and
validate clocks
On 14/11/2022 20:47, Robert Marko wrote:
> Now that we can match the platforms requiring clocks by compatible start
> using those to allow clocks per compatible and make them required.
>
> Signed-off-by: Robert Marko <robimarko@...il.com>
> ---
> Changes in v2:
> * Keep clocks under properties and disallow per compatible
> ---
> .../bindings/net/qcom,ipq4019-mdio.yaml | 27 ++++++++++++++-----
> 1 file changed, 20 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> index f4918c9e6fd2..72561e3aeee3 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
> @@ -9,9 +9,6 @@ title: Qualcomm IPQ40xx MDIO Controller
> maintainers:
> - Robert Marko <robert.marko@...tura.hr>
>
> -allOf:
> - - $ref: "mdio.yaml#"
> -
> properties:
> compatible:
> oneOf:
> @@ -40,10 +37,8 @@ properties:
> address range is only required by the platform IPQ50xx.
>
> clocks:
> - maxItems: 1
> - description: |
> - MDIO clock source frequency fixed to 100MHZ, this clock should be specified
> - by the platform IPQ807x, IPQ60xx and IPQ50xx.
> + items:
> + - description: MDIO clock source frequency fixed to 100MHZ
>
> required:
> - compatible
> @@ -51,6 +46,24 @@ required:
> - "#address-cells"
> - "#size-cells"
>
> +allOf:
> + - $ref: "mdio.yaml#"
If there is going to be resend, drop the quotes from above during the move.
Anyway:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists