linux-kernel - Re: [PATCH v2 0/5] Add kprobe and kretprobe support for LoongArch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1af099bf-123e-06bb-cd9a-5fd939f9cb79@loongson.cn>
Date:   Tue, 15 Nov 2022 16:44:05 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] Add kprobe and kretprobe support for LoongArch



On 11/14/2022 12:31 PM, Huacai Chen wrote:
> Hi, Tiezhu,
>
> Thanks for your patches, however,
> 1, You should rebase your code, since some functions such as
> is_pc_insn is provided in the github's loongarch-next branch;
> 2, Your code may have some problems about preemption, you can do
> something like this commit [1];
> 3, I don't think Kprobe should be enabled by default, distribution
> configs can enable it if needed.
>
> [1] https://github.com/loongson/linux/commit/023d5412ab5c154b87d57d70d465a4243df53717
>

OK, thank you, I will rebase and address the review comments,
and then send v3 later.

Thanks,
Tiezhu