[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221115091138.51614-1-wupeng58@huawei.com>
Date: Tue, 15 Nov 2022 09:11:38 +0000
From: Peng Wu <wupeng58@...wei.com>
To: <jwerner@...omium.org>, <jrosenth@...omium.org>,
<gregkh@...uxfoundation.org>, <groeck@...omium.org>
CC: <linux-kernel@...r.kernel.org>, <liwei391@...wei.com>,
Peng Wu <wupeng58@...wei.com>
Subject: [PATCH -next] firmware: google: fix a NULL vs IS_ERR() check in cbmem_entry_probe()
The devm_memremap() function returns error pointers on error,
it doesn't return NULL.
Fixes: 19d54020883c ("firmware: google: Implement cbmem in sysfs driver")
Signed-off-by: Peng Wu <wupeng58@...wei.com>
---
drivers/firmware/google/cbmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/google/cbmem.c b/drivers/firmware/google/cbmem.c
index 685f3070ce9d..88e587ba1e0d 100644
--- a/drivers/firmware/google/cbmem.c
+++ b/drivers/firmware/google/cbmem.c
@@ -106,8 +106,8 @@ static int cbmem_entry_probe(struct coreboot_device *dev)
entry->mem_file_buf = devm_memremap(&dev->dev, dev->cbmem_entry.address,
dev->cbmem_entry.entry_size,
MEMREMAP_WB);
- if (!entry->mem_file_buf)
- return -ENOMEM;
+ if (IS_ERR(entry->mem_file_buf))
+ return PTR_ERR(entry->mem_file_buf);
entry->size = dev->cbmem_entry.entry_size;
--
2.17.1
Powered by blists - more mailing lists