[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3NqY1xWTy7WzbHK@kroah.com>
Date: Tue, 15 Nov 2022 11:30:59 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: axboe@...nel.dk, linux-kernel@...r.kernel.org,
linux-block@...r.kernel.org
Subject: Re: [PATCH] blkdev: make struct block_device_operations.devnode()
take a const *
On Tue, Nov 15, 2022 at 01:13:07AM -0800, Christoph Hellwig wrote:
> On Wed, Nov 09, 2022 at 03:48:43PM +0100, Greg Kroah-Hartman wrote:
> > The devnode() callback in struct block_device_operations should not be
> > modifying the device that is passed into it, so mark it as a const * and
> > propagate the function signature changes out into the one subsystem that
> > actually uses this callback.
>
> Yes. In fact it really shouldn't exist at all. I wonder if we can
> do another attempt at dropping pktcdvd?
I'll gladly send a patch to delete it. Who objected last time? Let me
dig in the archives...
Powered by blists - more mailing lists