linux-kernel - Re: [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba0901a0-56c5-4e60-49b3-356899921934@baylibre.com>
Date:   Tue, 15 Nov 2022 11:34:41 +0100
From:   Alexandre Mergnat <amergnat@...libre.com>
To:     krzysztof.kozlowski@...aro.org
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        amergnat@...libre.com, angelogioacchino.delregno@...labora.com,
        broonie@...nel.org, chen.zhong@...iatek.com,
        devicetree@...r.kernel.org, dmitry.torokhov@...il.com,
        fabien.parent@...aro.org, fparent@...libre.com,
        krzysztof.kozlowski+dt@...aro.org, lee@...nel.org,
        lgirdwood@...il.com, linux-arm-kernel@...ts.infradead.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-rtc@...r.kernel.org, matthias.bgg@...il.com,
        mkorpershoek@...libre.com, pavel@....cz, robh@...nel.org,
        sean.wang@...iatek.com
Subject: Re: [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc
 documentation

Hi, thanks for your help

>>>> I checked and it doesn't support it but this needs to be fixed.  >>>> >>>>> What about rest of rtc.yaml schema? >>>>> >>>> >>>> 
wakeup-source would make sense but the driver doesn't support it yet. 
 >>> >>> The question is about hardware - does hardware support waking 
up the >>> system via interrupt? This is usually a domain of PMICs which 
still are >>> powered on when system sleeps. >>> >> >> I'd say that it 
is possible that a PMIC is able to wake up the system >> with or without 
having an interrupt wired to the SoC so wakeup-source >> makes sense. We 
don't need it if it is interrupt only. >
>Then I propose to reference the rtc.yaml.

I think I understand my error.
Actually, the RTC (HW) support the "start-year" feature, then I suggest
to fix the binding like that:

allOf:
   - $ref: "rtc.yaml#"

properties:
   compatible:
     enum:
       - mediatek,mt6323-rtc
       - mediatek,mt6357-rtc
       - mediatek,mt6358-rtc
       - mediatek,mt6366-rtc
       - mediatek,mt6397-rtc

   start-year: true

additionalProperties: false

required:
   - compatible

examples:
   - |
     pmic {
         rtc {
             compatible = "mediatek,mt6397-rtc";
         };
     };