linux-kernel - Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd13d08aaa288fe5cd401f2be678bb6e68662711.camel@mediatek.com>
Date:   Tue, 15 Nov 2022 11:57:43 +0000
From:   Irui Wang (王瑞) <Irui.Wang@...iatek.com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Tiffany Lin (林慧珊) 
        <tiffany.lin@...iatek.com>,
        "nicolas.dufresne@...labora.com" <nicolas.dufresne@...labora.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "acourbot@...omium.org" <acourbot@...omium.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Longfei Wang (王龙飞) 
        <Longfei.Wang@...iatek.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Maoguang Meng (孟毛广) 
        <Maoguang.Meng@...iatek.com>,
        Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder
 profile

Dear Hans,

Got it, thank you very much.

Best Regards
On Tue, 2022-11-15 at 12:49 +0100, Hans Verkuil wrote:
> Hi Irui,
> 
> On 11/15/22 12:40, Irui Wang (王瑞) wrote:
> > Dear Hans,
> > 
> > Gently ping for this patch.
> > May I know this patch current status? It seems is under your
> > reviewing
> > state?
> 
> Mauro was on vacation last week, but he said that he hopes to merge
> the pending PRs tomorrow. Fingers crossed...
> 
> Regards,
> 
> 	Hans
> 
> > 
> > Thanks
> > Best Regards
> > 
> > On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
> > > The encoder driver support h264 baseline, main, high encoder
> > > profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
> > > the unsupported profile.
> > > 
> > > get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
> > > h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
> > >         0: Baseline
> > >         2: Main
> > >         4: High
> > > 
> > > Signed-off-by: Irui Wang <irui.wang@...iatek.com>
> > > ---
> > >  drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5
> > > ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git
> > > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > index d810a78dde51..d65800a3b89d 100644
> > > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
> > > mtk_vcodec_ctx *ctx)
> > >  0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
> > >  v4l2_ctrl_new_std_menu(handler, ops,
> > > V4L2_CID_MPEG_VIDEO_H264_PROFILE,
> > >  V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> > > -0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> > > +~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
> > > > 
> > > 
> > > +  (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
> > > +  (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
> > > +V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> > >  v4l2_ctrl_new_std_menu(handler, ops,
> > > V4L2_CID_MPEG_VIDEO_H264_LEVEL,
> > >         h264_max_level,
> > >         0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
> > 
> > ************* MEDIATEK Confidentiality Notice
> >  ********************
> > The information contained in this e-mail message (including any 
> > attachments) may be confidential, proprietary, privileged, or
> > otherwise
> > exempt from disclosure under applicable laws. It is intended to be 
> > conveyed only to the designated recipient(s). Any use,
> > dissemination, 
> > distribution, printing, retaining or copying of this e-mail
> > (including its 
> > attachments) by unintended recipient(s) is strictly prohibited and
> > may 
> > be unlawful. If you are not an intended recipient of this e-mail,
> > or believe
> >  
> > that you have received this e-mail in error, please notify the
> > sender 
> > immediately (by replying to this e-mail), delete any and all copies
> > of 
> > this e-mail (including any attachments) from your system, and do
> > not
> > disclose the content of this e-mail to any other person. Thank you!
> 
>